GH-1246. Asynchronously initialize cache before reading II#1250
Conversation
|
Thanks for preparing this patch! I'd review it by the end of next week (sorry this week is a busy week for me >_<) |
tisonkun
left a comment
There was a problem hiding this comment.
Looks good and very tidy.
Thanks a lot for your contribution!
|
I'm waiting for other committers' review (cc @eolivelli @kezhuw @Randgalt @cammckenzie) but would otherwise merge this patch in the next week if there is no more objection. |
|
Thanks for taking a look @tisonkun! |
…ed/TestCachedModeledFramework.java Co-authored-by: Kezhu Wang <[email protected]>
|
Hey .. I just did a walk-through of the code again and have a question. Is applying the filter: safe to do from If it is ok then it is probably ok to remove the now unused methods in `ModeledCachedImpl: Either way I think a change is due ... let me know what you think! |
|
@kotman12 Let's removed the unused method in a follow-up PR. I'm going to merge this PR after CI green. |
|
Merged. Thanks for your contribution @kotman12! Would you provide a follow-up to remove the unused methods mentioned above? |
This is an alternative, simpler implementation to #1247 with the same motivation, namely to solve #1246