Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apache/curator
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: apache-curator-5.7.1
Choose a base ref
...
head repository: apache/curator
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: apache-curator-5.8.0
Choose a head ref
  • 19 commits
  • 101 files changed
  • 9 contributors

Commits on Oct 13, 2024

  1. Configuration menu
    Copy the full SHA
    07583f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Configuration menu
    Copy the full SHA
    6a27ff0 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2024

  1. Configuration menu
    Copy the full SHA
    72fd977 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ad19795 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2024

  1. Configuration menu
    Copy the full SHA
    eb99124 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2024

  1. Configuration menu
    Copy the full SHA
    dd67936 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2024

  1. Configuration menu
    Copy the full SHA
    6932a18 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2025

  1. Configuration menu
    Copy the full SHA
    0d6e457 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2025

  1. Configuration menu
    Copy the full SHA
    bdf2402 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2025

  1. CURATOR-728: Not issue ZooKeeper::create if possible in ZkPaths::mkdi…

    …rs (#518)
    
    `ZkPaths::mkdir("/bar/foo")` will not run into `NoAuthException` if
    "/bar/foo" exists, and we have `READ` permission to "/bar/foo" but not
    `CREATE` permission to "/bar".
    kezhuw authored Jan 9, 2025
    Configuration menu
    Copy the full SHA
    476268a View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2025

  1. [CURATOR-721] Upgrade Guava Listenablefuture (#509)

    This removes duplicate class ListenableFuture.
    
    See more at google/guava#7385
    froque authored Jan 10, 2025
    Configuration menu
    Copy the full SHA
    8bbcdbf View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2025

  1. Configuration menu
    Copy the full SHA
    3ccbad7 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2025

  1. CURATOR-729: Fix PersistentWatcher dead loop after curator closed (#520)

    The dead loop is multifold:
    1. `CuratorFramework::watchers` does not check `CuratorFrameworkState`
       as `getData` or others do.
    2. `PersistentWatcher` loops itself through `reset` in `BackgroundCallback`.
    3. Callback in `inBackground(callback).forPath(path)` is invoked
       synchronously.
    
    This commit enforces `CuratorFrameworkState` checking also to `watchers`,
    `watches`, `sync`, `reconfig` and `getConfig`.
    
    Additionally, this commit will issue `KeeperState.Closed` to listeners
    of `PersistentWatcher` when curator get closed. This is not required to
    fix CURATOR-729, but will make the closing behavior consistent with
    ZooKeeper. Also, I think it is good for asynchronous `Watcher`.
    
    Refs: CURATOR-529, CURATOR-673
    kezhuw authored Jan 16, 2025
    Configuration menu
    Copy the full SHA
    914f2f7 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2025

  1. Configuration menu
    Copy the full SHA
    8eb6f9a View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2025

  1. CURATOR-710: Fix leaking watch in EnsembleTracker (#508)

    CURATOR-667(#474) fixes asynchronous event path for `getConfig` to
    "/zookeeper/config" by using `CuratorFramework::usingNamespace(null)` to
    fetch data.
    
    It causes watcher not registering to possible `WatcherRemovalManager`,
    so leaking in `WatcherRemoveCuratorFramework::removeWatchers`.
    
    Signed-off-by: tison <[email protected]>
    Co-authored-by: tison <[email protected]>
    kezhuw and tisonkun authored Jan 19, 2025
    Configuration menu
    Copy the full SHA
    fb78e23 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2025

  1. CURATOR-718: Refactor CuratorFramework inheritance hierarchy by compo…

    …sing functionalities (#517)
    
    * CURATOR-718: Refactor CuratorFramework inheritance hierarchy by composing functionalities
    
    Currently, the `CuratorFrameworkImpl` hierarchy is neither simple nor
    composable.
    
    Ideally, there should be only one instance of `CuratorFrameworkImpl`. Additional functionalities should be added by intercepting methods on purpose, but not by cloning through `CuratorFrameworkImpl(CuratorFrameworkImpl parent)`.
    
    We could take CURATOR-626 and CURATOR-710 as lessons to know how brittle the current hierarchy.
    
    * fixup! CURATOR-718: Refactor CuratorFramework inheritance hierarchy by composing functionalities
    
    Notable changes to the last review:
    
    1. Rename `InternalCuratorFramework` to `CuratorFrameworkBase`.
    2. Make `DelegatingCuratorFramework` `abstract` and package `private`.
    3. Move `start`/`close` from `DelegatingCuratorFramework` to subclasses.
    kezhuw authored Feb 17, 2025
    Configuration menu
    Copy the full SHA
    f0646f9 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2025

  1. GH-1248. Fix bug of useSessionTimeoutMs overflow (#1249)

    Co-authored-by: 赵宝珠 <[email protected]>
    xingsuo-zbz and 赵宝珠 authored Feb 28, 2025
    Configuration menu
    Copy the full SHA
    0bb3adf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f3e129c View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2025

  1. Configuration menu
    Copy the full SHA
    cbafb53 View commit details
    Browse the repository at this point in the history
Loading