2598 wizard fauxton same origin #2
Conversation
src/setup.erl
Outdated
There was a problem hiding this comment.
If Options is a true {K,V} list, use lists:keyfind instead of proplists:is_defined. If you assume that Options may contain just remote_node with no associated value, then ignore this comment.
|
Wonder can we run these shell tests with |
|
@kxepal i fixed the usage of |
good question I also stumbled upon this. for now I just added another shell test to the ones that exist, we probably want to convert them to proper eunit tests in the future |
|
@robertkowalski good idea! |
src/setup.erl
Outdated
There was a problem hiding this comment.
There is no need in leading/trailing ~n when use couch_log as it already sets all new lines breaks right. That was reasonable for io:format/2, but only.
There was a problem hiding this comment.
oh i did not know! thank you - fixed!
|
fixed! |
|
@robertkowalski Looks good for me. Nice idea! (: P.S. To run tests the right cmd is |
|
+1 LGTM my build/ branch on couchdb.git introduces a few .sh scripts to test the build system itself in |
this feature makes it easier to setup a cluster for browser applications like fauxton as browsers follow the same-origin policy. Before this PR you had to open the wizard in Fauxton on all three nodes and enter your data there, which was quite confusing and hard to explain. Now you can stay in the same tab at the same address. This PR enables three new params in the body: `remote_node`: ip of the remote node where we want to send the `enable_cluster` request `remote_current_user`: the current admin username of the remote node `remote_current_password`: the current admin password of the remote node To test, I run: ``` rm -rf dev/lib/ && ./dev/run --no-join --admin=a:b ``` and then run the test script: ``` ./src/setup/test/t-frontend-setup.sh ``` COUCHDB-2598
robertkowalski
force-pushed
the
2598-wizard-fauxton-same-origin
branch
from
ebcf429 to
62c852a
Compare
this feature makes it easier to setup a cluster for browser applications like fauxton as browsers follow the same-origin policy. Before this PR you had to open the wizard in Fauxton on all three nodes and enter your data there, which was quite confusing and hard to explain. Now you can stay in the same tab at the same address. This PR enables three new params in the body: `remote_node`: ip of the remote node where we want to send the `enable_cluster` request `remote_current_user`: the current admin username of the remote node `remote_current_password`: the current admin password of the remote node To test, I run: ``` rm -rf dev/lib/ && ./dev/run --no-join --admin=a:b ``` and then run the test script: ``` ./src/setup/test/t-frontend-setup.sh ``` COUCHDB-2598 PR: #2 PR-URL: #2 Reviewed-By: Jan Lehnardt <[email protected]> Reviewed-By: Alexander Shorin <[email protected]>
PR: #2 PR-URL: #2 Reviewed-By: Jan Lehnardt <[email protected]> Reviewed-By: Alexander Shorin <[email protected]>
PR: #2 PR-URL: #2 Reviewed-By: Jan Lehnardt <[email protected]> Reviewed-By: Alexander Shorin <[email protected]>
3 participants
this feature makes it easier to setup a cluster for browser
applications like fauxton as browsers follow the same-origin
policy. Before this PR you had to open the wizard in Fauxton on
all three nodes and enter your data there, which was quite
confusing and hard to explain. Now you can stay in the same tab
at the same address.
This PR enables three new params in the body:
remote_node:ip of the remote node where we want to send the
enable_clusterrequest
remote_current_user:the current admin username of the remote node
remote_current_password:the current admin password of the remote node
To test, I run:
and then run the test script:
COUCHDB-2598