Bring smoosh in-tree #2326
Merged
Bring smoosh in-tree #2326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config_listener_mon establishes a monitor of the caller process. Therefore it is incorrect to call config:listen_for_changes from temporary process.
Update API for handle_config_terminate/3
Avoid using `erlang:now/0`
This patch allows administrators to configure smoosh to only execute compactions during a specified time window on a per-channel basis. The (partial) configuration looks like [smoosh] db_channels=overnight_channel [smoosh.overnight_channel] from = 22:00 to = 06:00 strict_window = true If `strict_window` is set to true, smoosh will suspend all currently running compactions in this channel when leaving the time window, and resume them in the next window. If left at the default, currently running compactions will be allowed to complete but no new compactions will be started until the window is open again.
Contributor
|
Doing a local build with |
asfgit
force-pushed
the
smoosh-in-tree
branch
from
34b485d to
02b9f25
Compare
Member
Author
|
Ah, thanks Nick that definitely points out what I was missing. Hopefully fixed the |
nickva
approved these changes
Nov 22, 2019
|
Hello. There was undefined module call couch_md_index_manager:get_group_pid ( https://github.com/apache/couchdb/pull/2326/files#diff-113cd247cfe56b1aa882a37daa2856fd33bab2e2a6183034eb3a30088960dc13R246 ). Could somebody explain me where i can find this module ? |
Contributor
|
@loguntsov that was an experimental "schema" discovery feature I believe that never made it into a release In the recent version of main the reference to that module should be removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds the auto-compaction daemon directly into the main repo. It also adds the "Support scheduling compactions during time windows" enhancement and related unit tests that were added to couchdb-smoosh after the 1.0.1 tag.
We use git-subtree to carry the smoosh history forward, with an invocation like
Testing recommendations
Check that the codebase is the same as you would get by moving the "smoosh" tag in rebar to "master".
Checklist
rel/overlay/etc/default.ini