MNG-6276 reproducible builds : ensure ZipEntry order in ParallelScatterZipCreator#77
Closed
Arnaud-Nauwynck wants to merge 2 commits intoapache:masterfrom
Arnaud-Nauwynck:master
Closed
MNG-6276 reproducible builds : ensure ZipEntry order in ParallelScatterZipCreator#77Arnaud-Nauwynck wants to merge 2 commits intoapache:masterfrom Arnaud-Nauwynck:master
Arnaud-Nauwynck wants to merge 2 commits intoapache:masterfrom
Arnaud-Nauwynck:master
Conversation
michael-o
reviewed
May 5, 2019
| return new OutputStream() { | ||
| @Override | ||
| public void write(int b) throws IOException { | ||
| byte[] data = new byte[] { (byte) b }; |
Member
There was a problem hiding this comment.
Allocating one-byte arrays? Won't this hurt performance?
Author
There was a problem hiding this comment.
Hi,
This method is necessary to implements OutputStream methods, and delegate to
ScatterGatherBackingStore.writeOut(byte[] data, int offset, int length) throws IOException;
Anyway, this method from this private adapter class is not used.
Maybe, It would be better that ScatterGatherBackingStore expose directly an OutputStream (but it would change signatures), or expose a unitary "write(byte data)"
Regards,
Member
|
Member
|
Many thanks @Arnaud-Nauwynck I've decided to use @hboutemy PR #78 instead of your version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.