Skip to content

Commit 974cf87

Browse files
garydgregorygarydgregory
committed
Remove redundant keywords
1 parent 0c82238 commit 974cf87

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

‎src/test/java/org/apache/commons/codec/net/URLCodecTest.java‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public void testBasicEncodeDecode() throws Exception {
5454
final String encoded = urlCodec.encode(plain);
5555
assertEquals("Hello+there%21", encoded, "Basic URL encoding test");
5656
assertEquals(plain, urlCodec.decode(encoded), "Basic URL decoding test");
57-
this.validateState(urlCodec);
57+
validateState(urlCodec);
5858
}
5959

6060
@Test
@@ -66,7 +66,7 @@ public void testDecodeInvalid() throws Exception {
6666
assertThrows(DecoderException.class, () -> urlCodec.decode("%WW"));
6767
// Bad 2nd char after %
6868
assertThrows(DecoderException.class, () -> urlCodec.decode("%0W"));
69-
this.validateState(urlCodec);
69+
validateState(urlCodec);
7070
}
7171

7272
@Test
@@ -79,7 +79,7 @@ public void testDecodeInvalidContent() throws DecoderException {
7979
for (int i = 0; i < input.length; i++) {
8080
assertEquals(input[i], output[i]);
8181
}
82-
this.validateState(urlCodec);
82+
validateState(urlCodec);
8383
}
8484

8585
@Test
@@ -97,7 +97,7 @@ public void testDecodeObjects() throws Exception {
9797
assertNull(result, "Decoding a null Object should return null");
9898

9999
assertThrows(DecoderException.class, () -> urlCodec.decode(Double.valueOf(3.0d)), "Trying to url encode a Double object should cause an exception.");
100-
this.validateState(urlCodec);
100+
validateState(urlCodec);
101101
}
102102

103103
@Test
@@ -123,15 +123,15 @@ public void testDefaultEncoding() throws Exception {
123123
final String encoded1 = urlCodec.encode(plain, "UnicodeBig");
124124
final String encoded2 = urlCodec.encode(plain);
125125
assertEquals(encoded1, encoded2);
126-
this.validateState(urlCodec);
126+
validateState(urlCodec);
127127
}
128128

129129
@Test
130130
public void testEncodeDecodeNull() throws Exception {
131131
final URLCodec urlCodec = new URLCodec();
132132
assertNull(urlCodec.encode((String) null), "Null string URL encoding test");
133133
assertNull(urlCodec.decode((String) null), "Null string URL decoding test");
134-
this.validateState(urlCodec);
134+
validateState(urlCodec);
135135
}
136136

137137
@Test
@@ -140,7 +140,7 @@ public void testEncodeNull() throws Exception {
140140
final byte[] plain = null;
141141
final byte[] encoded = urlCodec.encode(plain);
142142
assertNull(encoded, "Encoding a null string should return null");
143-
this.validateState(urlCodec);
143+
validateState(urlCodec);
144144
}
145145

146146
@Test
@@ -159,7 +159,7 @@ public void testEncodeObjects() throws Exception {
159159
assertNull(result, "Encoding a null Object should return null");
160160

161161
assertThrows(EncoderException.class, () -> urlCodec.encode(Double.valueOf(3.0d)), "Trying to url encode a Double object should cause an exception.");
162-
this.validateState(urlCodec);
162+
validateState(urlCodec);
163163
}
164164

165165
@Test
@@ -177,7 +177,7 @@ public void testEncodeUrlWithNullBitSet() throws Exception {
177177
final String encoded = new String(URLCodec.encodeUrl(null, plain.getBytes(StandardCharsets.UTF_8)));
178178
assertEquals("Hello+there%21", encoded, "Basic URL encoding test");
179179
assertEquals(plain, urlCodec.decode(encoded), "Basic URL decoding test");
180-
this.validateState(urlCodec);
180+
validateState(urlCodec);
181181
}
182182

183183
@Test
@@ -186,7 +186,7 @@ public void testInvalidEncoding() {
186186
final String plain = "Hello there!";
187187
assertThrows(EncoderException.class, () -> urlCodec.encode(plain), "We set the encoding to a bogus NONSENSE value");
188188
assertThrows(DecoderException.class, () -> urlCodec.decode(plain), "We set the encoding to a bogus NONSENSE value");
189-
this.validateState(urlCodec);
189+
validateState(urlCodec);
190190
}
191191

192192
@Test
@@ -196,7 +196,7 @@ public void testSafeCharEncodeDecode() throws Exception {
196196
final String encoded = urlCodec.encode(plain);
197197
assertEquals(plain, encoded, "Safe chars URL encoding test");
198198
assertEquals(plain, urlCodec.decode(encoded), "Safe chars URL decoding test");
199-
this.validateState(urlCodec);
199+
validateState(urlCodec);
200200
}
201201

202202
@Test
@@ -206,7 +206,7 @@ public void testUnsafeEncodeDecode() throws Exception {
206206
final String encoded = urlCodec.encode(plain);
207207
assertEquals("%7E%21%40%23%24%25%5E%26%28%29%2B%7B%7D%22%5C%3B%3A%60%2C%2F%5B%5D", encoded, "Unsafe chars URL encoding test");
208208
assertEquals(plain, urlCodec.decode(encoded), "Unsafe chars URL decoding test");
209-
this.validateState(urlCodec);
209+
validateState(urlCodec);
210210
}
211211

212212
@Test
@@ -216,14 +216,14 @@ public void testUTF8RoundTrip() throws Exception {
216216
final String ch_msg = constructString(SWISS_GERMAN_STUFF_UNICODE);
217217

218218
final URLCodec urlCodec = new URLCodec();
219-
this.validateState(urlCodec);
219+
validateState(urlCodec);
220220

221221
assertEquals("%D0%92%D1%81%D0%B5%D0%BC_%D0%BF%D1%80%D0%B8%D0%B2%D0%B5%D1%82", urlCodec.encode(ru_msg, CharEncoding.UTF_8));
222222
assertEquals("Gr%C3%BCezi_z%C3%A4m%C3%A4", urlCodec.encode(ch_msg, CharEncoding.UTF_8));
223223

224224
assertEquals(ru_msg, urlCodec.decode(urlCodec.encode(ru_msg, CharEncoding.UTF_8), CharEncoding.UTF_8));
225225
assertEquals(ch_msg, urlCodec.decode(urlCodec.encode(ch_msg, CharEncoding.UTF_8), CharEncoding.UTF_8));
226-
this.validateState(urlCodec);
226+
validateState(urlCodec);
227227
}
228228

229229
private void validateState(final URLCodec urlCodec) {

0 commit comments

Comments
 (0)