In-line single use test local variables

garydgregory · garydgregory · commit 8e36214fa276 · 2026-04-19T07:02:56.000-04:00
diff --git a/src/test/java/org/apache/commons/codec/language/Caverphone1Test.java b/src/test/java/org/apache/commons/codec/language/Caverphone1Test.java
@@ -65,8 +65,7 @@ void testCaverphoneRevisitedCommonCodeAT1111() throws EncoderException {
 
     @Test
     void testEndMb() throws EncoderException {
-        final String[][] data = {{"mb", "M11111"}, {"mbmb", "MPM111"}};
-        checkEncodings(data);
+        checkEncodings(new String[][] {{"mb", "M11111"}, {"mbmb", "MPM111"}});
     }
 
     /**
@@ -88,8 +87,7 @@ void testIsCaverphoneEquals() throws EncoderException {
      */
     @Test
     void testSpecificationV1Examples() throws EncoderException {
-        final String[][] data = {{"David", "TFT111"}, {"Whittle", "WTL111"}};
-        checkEncodings(data);
+        checkEncodings(new String[][] {{"David", "TFT111"}, {"Whittle", "WTL111"}});
     }
 
     /**
@@ -99,8 +97,7 @@ void testSpecificationV1Examples() throws EncoderException {
      */
     @Test
     void testWikipediaExamples() throws EncoderException {
-        final String[][] data = {{"Lee", "L11111"}, {"Thompson", "TMPSN1"}};
-        checkEncodings(data);
+        checkEncodings(new String[][] {{"Lee", "L11111"}, {"Thompson", "TMPSN1"}});
     }
 
 }
diff --git a/src/test/java/org/apache/commons/codec/language/Caverphone2Test.java b/src/test/java/org/apache/commons/codec/language/Caverphone2Test.java
@@ -68,8 +68,7 @@ void testCaverphoneRevisitedCommonCodeAT11111111() throws EncoderException {
      * @throws EncoderException for some failure scenarios     */
     @Test
     void testCaverphoneRevisitedExamples() throws EncoderException {
-        final String[][] data = {{"Stevenson", "STFNSN1111"}, {"Peter", "PTA1111111"}};
-        checkEncodings(data);
+        checkEncodings(new String[][] {{"Stevenson", "STFNSN1111"}, {"Peter", "PTA1111111"}});
     }
 
     /**
@@ -330,15 +329,14 @@ void testCaverphoneRevisitedRandomNameTTA1111111() throws EncoderException {
      * @throws EncoderException for some failure scenarios     */
     @Test
     void testCaverphoneRevisitedRandomWords() throws EncoderException {
-        checkEncodingVariations("RTA1111111", new String[]{"rather", "ready", "writer"});
+        checkEncodingVariations("RTA1111111", "rather", "ready", "writer");
         checkEncoding("SSA1111111", "social");
-        checkEncodingVariations("APA1111111", new String[]{"able", "appear"});
+        checkEncodingVariations("APA1111111", "able", "appear");
     }
 
     @Test
     void testEndMb() throws EncoderException {
-        final String[][] data = {{"mb", "M111111111"}, {"mbmb", "MPM1111111"}};
-        checkEncodings(data);
+        checkEncodings(new String[][] {{"mb", "M111111111"}, {"mbmb", "MPM1111111"}});
     }
 
     // Caverphone Revisited
@@ -351,15 +349,14 @@ void testIsCaverphoneEquals() throws EncoderException {
 
     @Test
     void testSpecificationExamples() throws EncoderException {
-        final String[][] data = {
+        checkEncodings(new String[][] {
             {"Peter", "PTA1111111"},
             {"ready", "RTA1111111"},
             {"social", "SSA1111111"},
             {"able", "APA1111111"},
             {"Tedder", "TTA1111111"},
             {"Karleen", "KLN1111111"},
-            {"Dyun", "TN11111111"}};
-        checkEncodings(data);
+            {"Dyun", "TN11111111"}});
     }
 
 }
diff --git a/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java b/src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java
@@ -246,8 +246,8 @@ void testExamples(final String source, final String expected) throws EncoderExce
 
     @Test
     void testHyphen() throws EncoderException {
-        final String[][] data = { { "bergisch-gladbach", "174845214" }, { "M\u00fcller-L\u00fcdenscheidt", "65752682" } }; // Müller-Lüdenscheidt
-        checkEncodings(data);
+        // Müller-Lüdenscheidt
+        checkEncodings(new String[][] { { "bergisch-gladbach", "174845214" }, { "M\u00fcller-L\u00fcdenscheidt", "65752682" } });
     }
 
     @ParameterizedTest

Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,7 @@ void testCaverphoneRevisitedCommonCodeAT1111() throws EncoderException {`
`65`	`65`
`66`	`66`	`@Test`
`67`	`67`	`void testEndMb() throws EncoderException {`
`68`		`- final String[][] data = {{"mb", "M11111"}, {"mbmb", "MPM111"}};`
`69`		`- checkEncodings(data);`
	`68`	`+ checkEncodings(new String[][] {{"mb", "M11111"}, {"mbmb", "MPM111"}});`
`70`	`69`	`}`
`71`	`70`
`72`	`71`	`/**`
`@@ -88,8 +87,7 @@ void testIsCaverphoneEquals() throws EncoderException {`
`88`	`87`	`*/`
`89`	`88`	`@Test`
`90`	`89`	`void testSpecificationV1Examples() throws EncoderException {`
`91`		`- final String[][] data = {{"David", "TFT111"}, {"Whittle", "WTL111"}};`
`92`		`- checkEncodings(data);`
	`90`	`+ checkEncodings(new String[][] {{"David", "TFT111"}, {"Whittle", "WTL111"}});`
`93`	`91`	`}`
`94`	`92`
`95`	`93`	`/**`
`@@ -99,8 +97,7 @@ void testSpecificationV1Examples() throws EncoderException {`
`99`	`97`	`*/`
`100`	`98`	`@Test`
`101`	`99`	`void testWikipediaExamples() throws EncoderException {`
`102`		`- final String[][] data = {{"Lee", "L11111"}, {"Thompson", "TMPSN1"}};`
`103`		`- checkEncodings(data);`
	`100`	`+ checkEncodings(new String[][] {{"Lee", "L11111"}, {"Thompson", "TMPSN1"}});`
`104`	`101`	`}`
`105`	`102`
`106`	`103`	`}`
Original file line number	Diff line number	Diff line change
`@@ -246,8 +246,8 @@ void testExamples(final String source, final String expected) throws EncoderExce`
`246`	`246`
`247`	`247`	`@Test`
`248`	`248`	`void testHyphen() throws EncoderException {`
`249`		`- final String[][] data = { { "bergisch-gladbach", "174845214" }, { "M\u00fcller-L\u00fcdenscheidt", "65752682" } }; // Müller-Lüdenscheidt`
`250`		`- checkEncodings(data);`
	`249`	`+ // Müller-Lüdenscheidt`
	`250`	`+ checkEncodings(new String[][] { { "bergisch-gladbach", "174845214" }, { "M\u00fcller-L\u00fcdenscheidt", "65752682" } });`
`251`	`251`	`}`
`252`	`252`
`253`	`253`	`@ParameterizedTest`