Skip to content

NSX: add back removed code for NSX #9435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nvazquez merged 1 commit into from
Aug 14, 2024
Merged

NSX: add back removed code for NSX #9435

nvazquez merged 1 commit into from
Aug 14, 2024

Conversation

@weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Jul 23, 2024

Description

The code snippet has been removed in the merge forward of PR #9240 in commit 90fe1d5

This PR adds the code back.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
NSX: add back removed code for NSX
48c7df0 
This code snippet has been removed in the merge forward of PR apache#9240
in commit 90fe1d5
@weizhouapache weizhouapache added this to the 4.20.0.0 milestone Jul 23, 2024
@codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 15.54%. Comparing base (d41dc17) to head (48c7df0).
Report is 34 commits behind head on main.

Files Patch % Lines
...tack/engine/orchestration/NetworkOrchestrator.java 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #9435      +/-   ##
============================================
- Coverage     15.54%   15.54%   -0.01%     
  Complexity    11977    11977              
============================================
  Files          5494     5494              
  Lines        481055   481059       +4     
  Branches      60787    59291    -1496     
============================================
- Hits          74771    74769       -2     
- Misses       398022   398027       +5     
- Partials       8262     8263       +1
Flag Coverage Δ
uitests 4.18% <ø> (ø)
unittests 16.31% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DaanHoogland
DaanHoogland approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Pearl1594
Pearl1594 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nvazquez
nvazquez approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @weizhouapache - LGTM

@yadvr
Copy link
Member

yadvr commented Jul 30, 2024

@nvazquez @Pearl1594 can there be some unit tests or integration to catch this?
@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 30, 2024

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jul 30, 2024

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10511

@nvazquez
Copy link
Contributor

nvazquez commented Aug 14, 2024

Merging based on approvals

@nvazquez nvazquez merged commit 3399abd into apache:main Aug 14, 2024
@DaanHoogland DaanHoogland deleted the 4.20-add-back-nsx branch August 14, 2024 18:06
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 22, 2024
@weizhouapache @dhslove
NSX: add back removed code for NSX (apache#9435)
c2eb871 
This code snippet has been removed in the merge forward of PR apache#9240
in commit 90fe1d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@nvazquez nvazquez nvazquez approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@vishesh92 vishesh92 Awaiting requested review from vishesh92

Assignees

No one assigned

Labels

component:orchestration

Projects

None yet

Milestone

4.20.0

Development

Successfully merging this pull request may close these issues.

6 participants

@weizhouapache @yadvr @blueorangutan @nvazquez @DaanHoogland @Pearl1594