Fix reference leak on AO/AOCS partition tables with unique index. #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
my-ship-it
reviewed
Sep 30, 2024
Fix apache#557. This is introduced by GPDB commit ed364586b99. For AO/AOCS partition tables, it's possible to update across partitions. And it does have deleteDesc and uniqueCheckDesc if there were. The DeleteDesc and InsertDesc are not enough to decide if the partition has a update operation or not. Some partitions have visimap but some not, clean them if possible. Authored-by: Zhang Mingli [email protected]
Authored-by: Zhang Mingli [email protected]
avamingli
force-pushed
the
fix_ao_unique
branch
from
103b241 to
d3388f5
Compare
2 tasks
my-ship-it
approved these changes
Oct 8, 2024
Contributor
Author
|
Pushed, thanks for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #557.
This issue also exists for AOCS.
This is introduced by GPDB commit ed364586b99.
For AO/AOCS partition tables, it's possible to update across partitions.
And it does have deleteDesc and uniqueCheckDesc if there were.
The DeleteDesc and InsertDesc are not enough to decide if the partition has a update operation or not.
Some partitions have visimap but some not, clean them if possible.
Authored-by: Zhang Mingli [email protected]
fix #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallelcloudberrydb/devteam for review and approval when your PR is ready🥳