Skip to content

Conversation

@turboFei
Copy link
Member

@turboFei turboFei commented Feb 23, 2024

What changes were proposed in this pull request?

Refer SPARK-37894/ apache/spark#35276
Avoid calculating all outstanding requests to improve performance

Why are the changes needed?

Ditto.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Not needed.

@turboFei turboFei force-pushed the SPARK-37984_backport branch from 82edfd5 to 4be83ae Compare February 23, 2024 02:50
@turboFei turboFei changed the title Avoid calculating all outstanding requests to improve performance [CELEBORN-1278] Avoid calculating all outstanding requests to improve performance Feb 23, 2024
@turboFei
Copy link
Member Author

This issue is fixed by SPARK-37894

@codecov
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 48.73%. Comparing base (0c952ca) to head (4be83ae).
Report is 3 commits behind head on main.

Files Patch % Lines
...ommon/network/client/TransportResponseHandler.java 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2319      +/-   ##
==========================================
- Coverage   48.87%   48.73%   -0.13%     
==========================================
  Files         207      207              
  Lines       12936    12978      +42     
  Branches     1114     1117       +3     
==========================================
+ Hits         6321     6324       +3     
- Misses       6208     6246      +38     
- Partials      407      408       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FMX FMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Merged into main(v0.5.0) and branch-0.4(v0.4.1).

@FMX FMX closed this in 621a719 Feb 23, 2024
FMX pushed a commit that referenced this pull request Feb 23, 2024
… performance

### What changes were proposed in this pull request?
Refer [SPARK-37894](https://issues.apache.org/jira/browse/SPARK-37984)/ apache/spark#35276
Avoid calculating all outstanding requests to improve performance

### Why are the changes needed?
Ditto.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?
Not needed.

Closes #2319 from turboFei/SPARK-37984_backport.

Authored-by: Fei Wang <[email protected]>
Signed-off-by: mingji <[email protected]>
(cherry picked from commit 621a719)
Signed-off-by: mingji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants