feat: Add default container annotation for kubectl commands #6405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squakez
reviewed
Dec 12, 2025
Contributor
squakez
left a comment
squakez
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I will give a deeper look asap. In the while, we better use a constant for the annotation.
Contributor
|
✔️ Unit test coverage report - coverage increased from 51.5% to 51.6% (+0.1%) |
Contributor
Author
|
@squakez I have replaced the hardcoded annotation string with defaultContainerAnnotation constant. Regarding CI, Kafka test was failing, I remember you mentioned once it acts flaky sometimes. |
Contributor
|
✔️ Unit test coverage report - coverage increased from 51.5% to 51.6% (+0.1%) |
squakez
approved these changes
Dec 12, 2025
Contributor
squakez
left a comment
squakez
left a comment
There was a problem hiding this comment.
Cool work! +1 for the unit test!
Contributor
Author
|
@squakez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds the annotation
kubectl.kubernetes.io/default-container: integrationto pod templates for the following:This allows kubectl to automatically target the integration container.
Closes #2200