fix(ci): enable perfsprint, testpackage and fixed violations #6373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Nov 16, 2025
squakez
approved these changes
Nov 17, 2025
Contributor
squakez
left a comment
squakez
left a comment
There was a problem hiding this comment.
LGTM, thanks. Given that each lint is requiring many fixes, probably it will be better to created a single PR per each lint if you're continuing to work on this task. It will be easier for us to review.
Contributor
Author
|
@squakez sure. Will keep it that way only. |
gansheer
approved these changes
Nov 17, 2025
squakez
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled perfsprint and test package and fixed all arising violations.
Issue: #5486