fix(ci): enable forbidigo ,tagalign and fix violations #6370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gansheer
approved these changes
Nov 15, 2025
Contributor
Author
|
@squakez Resolved conflict. |
squakez
approved these changes
Nov 16, 2025
Contributor
|
|
Contributor
Author
|
@squakez Do you plan to merger this later ? just asking, so I can avoid stacking conflicts in the next PR. |
Contributor
|
I cannot merge due to conflicts. As soon as you rebase and clear the conflicts I will be able to merge it. |
pkalsi97
force-pushed
the
ci/enable-forbidigo-tagalign
branch
from
11b4a0a to
f266094
Compare
Contributor
Author
|
@squakez my bad, I missed the conflict earlier. It's resolved now. |
Contributor
Author
|
@squakez just confirming, do you still see any conflicts ? The UI is not showing any, even previously it was not showing (not sure why). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the forbidigo and tagalign linters and fix violations.
Issue: #5486