Skip to content

Conversation

@pkalsi97
Copy link
Contributor

@pkalsi97 pkalsi97 commented Nov 15, 2025

Enables the whitespace linter in .golangci.yml and removes all reported leading/trailing blank-line violations across the codebase.

Issue: #5486

@pkalsi97 pkalsi97 changed the title ci: enable whitespace linter and fix violations fix(ci): enable whitespace linter and fix violations Nov 15, 2025
@pkalsi97
Copy link
Contributor Author

@squakez
I am more than willing on to work on lint enforcement and fixing violations, but I need some input from you :
Should each rule enablement and its fixes be submitted as an isolated PR? Or is it acceptable to group multiple rules and fixes into a single PR when the changes are related?

disable:
    - cyclop
    - depguard
    - err113
    - exhaustive
    - exhaustruct
    - funcorder
    - funlen
    - gochecknoglobals
    - gochecknoinits
    - gocognit
    - gocyclo
    - godox
    - ireturn
    - lll
    - nilnil
    - nlreturn
    - paralleltest
    - perfsprint
    - revive
    - tagalign
    - tagliatelle
    - testpackage
    - varnamelen
    - whitespace
    - wrapcheck
    - wsl
    - wsl_v5

Can you list down the ones you think should not be in disable, I'll work on those only.

@squakez
Copy link
Contributor

squakez commented Nov 15, 2025

@pkalsi97 I have no preferences. It's more about how you prefer to do the development. What I think it matters is to use a single PR per each different linter when the changes required in the codebase are large and require some discussion. Otherwise, if it does not require large codebase changes, then, you can join more lint in each PR.

@squakez squakez merged commit b817a3f into apache:main Nov 15, 2025
10 checks passed
@pkalsi97 pkalsi97 deleted the ci/enable-whitespace branch November 15, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants