cli(reset): add force flag, namespace confirmation prompt, update e2e test #6359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squakez
approved these changes
Nov 4, 2025
Contributor
squakez
left a comment
squakez
left a comment
There was a problem hiding this comment.
Cool stuff. Thanks for the contribution!
Contributor
|
|
Contributor
Author
@squakez I'll investigate why test are still failing and implement the fix. |
Contributor
|
Ok. I restarted Kafka test, sometimes is flaky. Only |
Contributor
Author
|
@squakez I have added the fix, a minor error e2e test expected flag to be -f where as in cmd its setup as --force |
Contributor
|
|
gansheer
approved these changes
Nov 5, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Based on @squakez feedback on implementation of a confirmation step in
resetcommand -– Added
Force(--force) option– Added namespace confirmation when not forced
– Updated e2e tests to use
-f– Supersedes previous PR #6356 because that branch used an invalid Unicode character in its name, breaking GitHub branch tracking
Thank you for the opportunity 😄