feat(cli): add namespace confirmation prompt to 'kamel reset' #6356
Conversation
squakez
left a comment
squakez
left a comment
There was a problem hiding this comment.
Thanks for the PR! LGTM, only mind the github warning about the illegal char in the branch name please.
|
|
|
@squakez Shall I fix the branch name ? sorry for that! |
|
|
|
@squakez I apologise for the mess, please Review the changes again. |
pkg/cmd/reset.go
Outdated
| } | ||
|
|
||
| func (o *resetCmdOptions) reset(cmd *cobra.Command, _ []string) { | ||
| if cmd.InOrStdin() == os.Stdin { |
There was a problem hiding this comment.
I think it would be better to include a -f/--force option to skip the check entirely. As shown by the e2e test it is possible that some user leverage the command automatically, so we need some possibility to skip the check and force the reset without prompting. In that case, you can change the test to pass a -f and make it pass.
|
About the branch name, I can see github complaining about the presence of the |
pkalsi97
force-pushed
the
cli/reset‐confirmation
branch
from
7e4f661 to
5504c3a
Compare
2 participants
Implements additional Input of namespace (and confirms it) before reset in CLI.
Closes #6299