refactor: move knative types out of API package (#6300) #6355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed knative types from pkg/apis since they are internal. Relocated to pkg/internal/knative. Prevents util <-> trait circular dependency.
squakez
approved these changes
Nov 3, 2025
Contributor
squakez
left a comment
squakez
left a comment
There was a problem hiding this comment.
Thanks for the PR! Yeah, either internal or the same util could have worked.
Contributor
Author
|
@squakez I have fixed the issues that were causing CI to fail. |
gansheer
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed knative types from pkg/apis since they are internal.
Relocated to pkg/internal/knative.
Did not move them to pkg/traits as this would cause util <-> trait circular dependency.
Closes #6300
@squakez, Please Review when ever you see fit!