Issue #6334 Flaky TestKedaAuthentication unit test #6337
Issue #6334 Flaky TestKedaAuthentication unit test #6337gansheer merged 2 commits intoapache:mainfrom
Conversation
squakez
left a comment
There was a problem hiding this comment.
Thanks for the PR. I think this is the same as we had. The problem with the flakiness is that sometimes you get elements either in position 0 or 1, so it's not reliable. Ideally you need two assert.Contains in order to validate the output regardless of the array position.
I think it's good according to the doc: https://pkg.go.dev/github.com/stretchr/testify/assert#ElementsMatch |
|
Didn't know that. Thanks for checking @gansheer - approved then! |
|
Thanks for quick turnaround! |
|
Hey guys is it normal for advanced to fail multiple times? Also I usually have Merge PR button on my local machine. Does this work differently with open source or auto-merges? |
Yes, unfortunately. We have some instability in the test run. It has gotten better but not the best it could yet. |
#6334
Release Note