Skip to content

feat(traits): new keda implementation #6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
squakez merged 2 commits into from
Oct 6, 2025
Merged

feat(traits): new keda implementation #6311

squakez merged 2 commits into from
Oct 6, 2025

Conversation

@squakez
Copy link
Contributor

@squakez squakez commented Oct 4, 2025

  • Moved from addons
  • Newer implementation which is not yet automatic
  • Removed addons folder and logic
  • E2E test to cover Kafka serverless

Closes #6288

Release Note

NONE

@squakez squakez mentioned this pull request Oct 4, 2025
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

⚠️ Unit test coverage report - coverage decreased from 51.4% to 51.2% (-0.2%)

@squakez
feat(traits): new keda implementation
3181563 
* Moved from addons
* Newer implementation which is not yet automatic
* Removed addons folder and logic
* E2E test to cover Kafka serverless

Closes apache#6288
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

⚠️ Unit test coverage report - coverage decreased from 51.4% to 51.2% (-0.2%)

@squakez
Copy link
Contributor Author

squakez commented Oct 5, 2025

The Knative serverless test is failing because we're setting the annotation "autoscaling.knative.dev/minScale": "1". This is due to the new default required for Keda, and the assumption that such a value is 1 instead of 0, as expected by Knative serving.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2025

⚠️ Unit test coverage report - coverage decreased from 51.4% to 51.3% (-0.1%)

@gansheer
Copy link
Contributor

gansheer commented Oct 5, 2025

LGTM (minus the lint issue)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

⚠️ Unit test coverage report - coverage decreased from 51.4% to 51.3% (-0.1%)

@squakez squakez merged commit e6cf286 into apache:main Oct 6, 2025
10 checks passed
@squakez squakez deleted the feat/6288 branch October 6, 2025 12:27
@BrewTestBot BrewTestBot mentioned this pull request Dec 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gansheer gansheer gansheer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New KEDA trait

2 participants

@squakez @gansheer