Skip to content

feat(traits): new keda implementation#6311

Merged
squakez merged 2 commits intoapache:mainfrom
squakez:feat/6288
Oct 6, 2025
Merged

feat(traits): new keda implementation#6311
squakez merged 2 commits intoapache:mainfrom
squakez:feat/6288

Conversation

@squakez
Copy link
Copy Markdown
Contributor

@squakez squakez commented Oct 4, 2025

  • Moved from addons
  • Newer implementation which is not yet automatic
  • Removed addons folder and logic
  • E2E test to cover Kafka serverless

Closes #6288

Release Note

NONE

@squakez squakez mentioned this pull request Oct 4, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 4, 2025

⚠️ Unit test coverage report - coverage decreased from 51.4% to 51.2% (-0.2%)

* Moved from addons
* Newer implementation which is not yet automatic
* Removed addons folder and logic
* E2E test to cover Kafka serverless

Closes apache#6288
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 4, 2025

⚠️ Unit test coverage report - coverage decreased from 51.4% to 51.2% (-0.2%)

@squakez
Copy link
Copy Markdown
Contributor Author

squakez commented Oct 5, 2025

The Knative serverless test is failing because we're setting the annotation "autoscaling.knative.dev/minScale": "1". This is due to the new default required for Keda, and the assumption that such a value is 1 instead of 0, as expected by Knative serving.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 5, 2025

⚠️ Unit test coverage report - coverage decreased from 51.4% to 51.3% (-0.1%)

@gansheer
Copy link
Copy Markdown
Contributor

gansheer commented Oct 5, 2025

LGTM (minus the lint issue)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 6, 2025

⚠️ Unit test coverage report - coverage decreased from 51.4% to 51.3% (-0.1%)

@squakez squakez merged commit e6cf286 into apache:main Oct 6, 2025
10 checks passed
@squakez squakez deleted the feat/6288 branch October 6, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New KEDA trait

2 participants