Skip to content

fix(helm): extra environment variables #6092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
squakez merged 1 commit into from
Mar 1, 2025
Merged

fix(helm): extra environment variables #6092

squakez merged 1 commit into from
Mar 1, 2025

Conversation

@eshepelyuk
Copy link
Contributor

@eshepelyuk eshepelyuk commented Feb 28, 2025

Possibility to define extra environment variables for operator deployment / pod.
Can be used for example to access private GitHub repositories for downloading custom Kamelet.

Zulip thread

Release Note

fix(helm): extra environment variables

@eshepelyuk
fix(helm): extra environment variables
f57d475 
Signed-off-by: Ievgenii Shepeliuk <[email protected]>
squakez
squakez reviewed Mar 1, 2025
View reviewed changes
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though, I'd change the name of the parameter.

@squakez squakez merged commit 4d59eb7 into apache:main Mar 1, 2025
9 checks passed
@squakez
Copy link
Contributor

squakez commented Mar 1, 2025

Thanks!

@eshepelyuk eshepelyuk deleted the fix/helm-env branch March 1, 2025 09:51
@eshepelyuk
Copy link
Contributor Author

eshepelyuk commented Mar 1, 2025

Thanks!

Thanks for accepting my PR. Do you have any ETA for releasing this ?

@squakez
Copy link
Contributor

squakez commented Mar 3, 2025

Thanks for accepting my PR. Do you have any ETA for releasing this ?

Probably in 2.7.0 which is planned to be released in May/June.

@eshepelyuk
Copy link
Contributor Author

eshepelyuk commented Mar 3, 2025

Thanks for accepting my PR. Do you have any ETA for releasing this ?

Probably in 2.7.0 which is planned to be released in May/June.

Is it possible to release Helm chart only patch version for 2.6 ?

@squakez
Copy link
Contributor

squakez commented Mar 3, 2025

Is it possible to release Helm chart only patch version for 2.6 ?

You can backport to release-2.6.x and if we go through some patch release it will be there for sure.

@eshepelyuk
Copy link
Contributor Author

eshepelyuk commented Mar 3, 2025

Is it possible to release Helm chart only patch version for 2.6 ?

You can backport to release-2.6.x and if we go through some patch release it will be there for sure.

can you please provide more details how should i do this ?

@squakez
Copy link
Contributor

squakez commented Mar 3, 2025 •
edited
Loading

can you please provide more details how should i do this ?

Sure. You should git cherry-pick this PR merged commit in release-2.6.x branch and issue a PR with the change.

@eshepelyuk
Copy link
Contributor Author

eshepelyuk commented Mar 3, 2025

can you please provide more details how should i do this ?

Sure. You should git cherry-pick this PR merged commit in release-2.6.x branch and issue a PR with the change.

Hello @squakez
Created #6094

@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@squakez squakez squakez left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eshepelyuk @squakez