[BEAM-4571] RedisIO support for write using SET operation#6045
Merged
jbonofre merged 4 commits intoapache:masterfrom Aug 13, 2018
Merged
[BEAM-4571] RedisIO support for write using SET operation#6045jbonofre merged 4 commits intoapache:masterfrom
jbonofre merged 4 commits intoapache:masterfrom
Conversation
Contributor
Author
|
retest this please |
1 similar comment
Contributor
Author
|
retest this please |
Contributor
Author
|
Hi, is there any comment on this pull request? |
jbonofre
requested changes
Aug 12, 2018
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
Overall looks good. Can you please just change the test methods ? I will merge just after.
|
|
||
| @Test | ||
| public void testWriteRead() throws Exception { | ||
| public void testWriteRead_append() throws Exception { |
Member
There was a problem hiding this comment.
For consistency, I would use testWriteReadAppend().
| } | ||
|
|
||
| @Test | ||
| public void testWriteRead_set() throws Exception { |
Contributor
Author
|
retest this please |
1 similar comment
Contributor
Author
|
retest this please |
Contributor
Author
|
Thanks for your review @jbonofre. I've made the changes and the build is good. Let me know if there is anything else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for set, lpush, and rpush Redis operations, including setting expire time
R: @jbonofre