fix(pipeline): Handle missing side_inputs in AppliedPTransform#36238
fix(pipeline): Handle missing side_inputs in AppliedPTransform#36238liferoad merged 1 commit intoapache:masterfrom
Conversation
The AppliedPTransform initialization previously accessed `transform.side_inputs` directly. This could lead to an `AttributeError` if a transform object did not have a `side_inputs` attribute. This change uses `getattr` to safely access the attribute, providing an empty tuple as a default value. This makes the pipeline construction more robust by preventing crashes for transforms that do not define side inputs.
Summary of ChangesHello @liferoad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the robustness of the pipeline construction process by addressing a potential Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #36238 +/- ##
============================================
- Coverage 54.93% 54.92% -0.01%
Complexity 1617 1617
============================================
Files 1057 1057
Lines 164425 164395 -30
Branches 1165 1165
============================================
- Hits 90320 90293 -27
+ Misses 71955 71953 -2
+ Partials 2150 2149 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
The AppliedPTransform initialization previously accessed
transform.side_inputsdirectly. This could lead to anAttributeErrorif a transform object did not have aside_inputsattribute.This change uses
getattrto safely access the attribute, providing an empty tuple as a default value. This makes the pipeline construction more robust by preventing crashes for transforms that do not define side inputs.Fixes #33854
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.