Migrate "beam_PostCommit_Python_ValidatesRunner_*" Jenkins jobs to GitHub Actions#28439
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| cache-read-only: false | ||
| - name: Configure passenv for tox | ||
| run: | | ||
| sed -i '/^\[testenv\]$/,/^\[/ s/^passenv=TERM/passenv=TERM,CLOUDSDK_CONFIG/' sdks/python/tox.ini |
There was a problem hiding this comment.
Can we just update the tox.ini file to incude CLOUDSDK_CONFIG in passenv? This is fragile and would break if you removed TERM from passenv.
There was a problem hiding this comment.
Added CLOUDSDK_CONFIG to the tox.ini file. Not sure if adding this variable will affect/cause some jobs to fail, but let's keep an eye on it.
damccorm
left a comment
damccorm
left a comment
There was a problem hiding this comment.
Had one comment, otherwise LGTM
Codecov Report
@@ Coverage Diff @@
## master #28439 +/- ##
==========================================
+ Coverage 72.30% 72.33% +0.02%
==========================================
Files 683 683
Lines 100604 100709 +105
==========================================
+ Hits 72745 72847 +102
- Misses 26282 26285 +3
Partials 1577 1577
Flags with carried forward coverage won't be shown. Click here to find out more. see 18 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Will merge once checks complete |
…tHub Actions (apache#28439) * added beam_PostCommit_Python_ValidatesRunner jobs to GitHub Actions * added beam_PostCommit_Python_ValidatesRunner jobs to GitHub Actions * added beam_PostCommit_Python_ValidatesRunner jobs to GitHub Actions
2 participants
The following jenkins jobs have been migrated:
How has it been tested?
The jobs have been tested on Self-hosted GKE runners ubuntu 20.04.
The following test cases are passed:
workflow_dispatch)Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.