Remove level and errors arguments for Pandas 2 compatibility. #28375
Merged
tvalentyn merged 23 commits intoapache:masterfrom Sep 13, 2023
Merged
Remove level and errors arguments for Pandas 2 compatibility. #28375tvalentyn merged 23 commits intoapache:masterfrom
tvalentyn merged 23 commits intoapache:masterfrom
Conversation
Level was always NotImplemented anyway, and errors I conditionally disable based on the pandas version to keep functionality.
caneff
changed the title
Contributor
Author
|
R: @tvalentyn |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #28375 +/- ##
==========================================
- Coverage 72.32% 72.30% -0.02%
==========================================
Files 683 683
Lines 100620 100638 +18
==========================================
- Hits 72776 72770 -6
- Misses 26266 26290 +24
Partials 1578 1578
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Pandas removed .append in 2.0 so this helps keep the API consistent.
tvalentyn
reviewed
Sep 11, 2023
tvalentyn
approved these changes
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the new removed_args functionality for these.
Partially fixing #27221