Skip to content

Clarify llm download/loading instructions#25145

Merged
damccorm merged 5 commits intomasterfrom
users/damccorm/llm
Feb 5, 2023
Merged

Clarify llm download/loading instructions#25145
damccorm merged 5 commits intomasterfrom
users/damccorm/llm

Conversation

@damccorm
Copy link
Copy Markdown
Contributor

Adds some more details from going through the instructions.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 1, 2023

Codecov Report

Merging #25145 (12e829e) into master (89cd059) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25145      +/-   ##
==========================================
+ Coverage   73.05%   73.07%   +0.01%     
==========================================
  Files         740      740              
  Lines       98734    98773      +39     
==========================================
+ Hits        72132    72177      +45     
+ Misses      25238    25232       -6     
  Partials     1364     1364              
Flag Coverage Δ
python 82.51% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ython/apache_beam/runners/interactive/sql/utils.py 76.09% <0.00%> (ø)
...ache/beam/model/fn_execution/v1/beam_fn_api_pb2.py 100.00% <0.00%> (ø)
...ache/beam/model/pipeline/v1/beam_runner_api_pb2.py 100.00% <0.00%> (ø)
...beam/model/pipeline/v1/beam_runner_api_pb2_urns.py 100.00% <0.00%> (ø)
sdks/python/apache_beam/typehints/typehints.py 92.89% <0.00%> (+0.01%) ⬆️
sdks/python/apache_beam/transforms/util.py 96.28% <0.00%> (+0.04%) ⬆️
...hon/apache_beam/runners/worker/bundle_processor.py 93.67% <0.00%> (+0.12%) ⬆️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.24% <0.00%> (+0.16%) ⬆️
sdks/python/apache_beam/io/source_test_utils.py 89.86% <0.00%> (+1.38%) ⬆️
sdks/python/apache_beam/utils/interactive_utils.py 97.56% <0.00%> (+2.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damccorm
Copy link
Copy Markdown
Contributor Author

damccorm commented Feb 2, 2023

Run Python_Runners PreCommit

@damccorm
Copy link
Copy Markdown
Contributor Author

damccorm commented Feb 2, 2023

Run Python_Transforms PreCommit

@damccorm damccorm marked this pull request as ready for review February 2, 2023 17:04
@damccorm
Copy link
Copy Markdown
Contributor Author

damccorm commented Feb 2, 2023

R: @shub-kris

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@shub-kris
Copy link
Copy Markdown
Contributor

Hi @damccorm the additions to the documentation looks good to me.

Thanks for making it more detailed.

@damccorm damccorm merged commit aee2c84 into master Feb 5, 2023
@damccorm damccorm deleted the users/damccorm/llm branch February 5, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants