Skip to content

Uses _all to follow alias/datastreams when estimating index size #24186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aromanenko-dev merged 2 commits into from
Nov 17, 2022
Merged

Uses _all to follow alias/datastreams when estimating index size #24186

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a014637
Uses _all to follow alias/datastreams when estimating index size
egalpin Nov 15, 2022
ce8d618
Adds test for following aliases when estimating index size
egalpin Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Uses _all to follow alias/datastreams when estimating index size 
Fixes #24117
  • Loading branch information
@egalpin
egalpin committed Nov 15, 2022
commit a014637106970a0a0e9eb7944aa5caf79fa5fd37
17 changes: 6 additions & 11 deletions .../io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,9 +873,8 @@ public long getEstimatedSizeBytes(PipelineOptions options) throws IOException {
return estimatedByteSize;
}
final ConnectionConfiguration connectionConfiguration = spec.getConnectionConfiguration();
JsonNode statsJson = getStats(connectionConfiguration, false);
JsonNode indexStats =
statsJson.path("indices").path(connectionConfiguration.getIndex()).path("primaries");
JsonNode statsJson = getStats(connectionConfiguration);
JsonNode indexStats = statsJson.path("_all").path("primaries");
long indexSize = indexStats.path("store").path("size_in_bytes").asLong();
LOG.debug("estimate source byte size: total index size {}", indexSize);

Expand Down Expand Up @@ -927,9 +926,8 @@ static long estimateIndexSize(ConnectionConfiguration connectionConfiguration)
// NB: Elasticsearch 5.x+ now provides the slice API.
// (https://www.elastic.co/guide/en/elasticsearch/reference/5.0/search-request-scroll.html
// #sliced-scroll)
JsonNode statsJson = getStats(connectionConfiguration, false);
JsonNode indexStats =
statsJson.path("indices").path(connectionConfiguration.getIndex()).path("primaries");
JsonNode statsJson = getStats(connectionConfiguration);
JsonNode indexStats = statsJson.path("_all").path("primaries");
JsonNode store = indexStats.path("store");
return store.path("size_in_bytes").asLong();
}
Expand All @@ -956,12 +954,9 @@ public Coder<String> getOutputCoder() {
return StringUtf8Coder.of();
}

private static JsonNode getStats(
ConnectionConfiguration connectionConfiguration, boolean shardLevel) throws IOException {
private static JsonNode getStats(ConnectionConfiguration connectionConfiguration)
throws IOException {
HashMap<String, String> params = new HashMap<>();
if (shardLevel) {
params.put("level", "shards");
}
String endpoint = String.format("/%s/_stats", connectionConfiguration.getIndex());
try (RestClient restClient = connectionConfiguration.createClient()) {
Request request = new Request("GET", endpoint);
Expand Down