[23832] Remove ParquetIO.withSplit#23833
Merged
mosche merged 2 commits intoapache:masterfrom Oct 26, 2022
Merged
Conversation
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
Author
|
Run Java ParquetIO Performance Test |
Contributor
Author
|
Run Spark Runner Tpcds Tests |
Contributor
Author
|
R: @mosche |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
mosche
approved these changes
Oct 26, 2022
Member
mosche
left a comment
mosche
left a comment
There was a problem hiding this comment.
Thanks, always great to remove a bunch of old obsolete code 🥇
LGTM 😄
Co-authored-by: Moritz Mack <[email protected]>
Member
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
Thanks a lot for following up on this :)
4 tasks
ryanthompson591
pushed a commit
to ryanthompson591/beam
that referenced
this pull request
Oct 28, 2022
ruslan-ikhsan
pushed a commit
to akvelon/beam
that referenced
this pull request
Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following BEAM-12070 where ParquetIO.withSplit became a default behaviour and taking into account the fact that no related issues were reported in the last several Beam releases (since Beam 2.35.0), we may drop such functionality as it was planned before.
Fixes #23832
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.