[BEAM-14039] Propagate ignore_unknown_columns parameter.#16999
Conversation
Right now, the ignore_unknown_columns parameter is never passed from WriteToBigquery to _StreamToBigQuery and therefore never reaches the bq_client.insert_rows_json method.
Codecov Report
@@ Coverage Diff @@
## master #16999 +/- ##
==========================================
- Coverage 73.83% 73.82% -0.01%
==========================================
Files 664 664
Lines 87272 87273 +1
==========================================
- Hits 64434 64431 -3
- Misses 21735 21739 +4
Partials 1103 1103
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
Author
|
r: @pabloem (since you introduced the parameter originally) |
Contributor
Author
|
r: @youngoli (since you reviewed the PR which introduced it originally) |
Member
|
LGTM! |
Member
|
Run Python 3.8 PostCommit |
youngoli
approved these changes
Mar 10, 2022
Contributor
youngoli
left a comment
youngoli
left a comment
There was a problem hiding this comment.
Looks good to me. I'll leave it to Pablo to merge.
Member
|
@pabloem maybe follow up with some tests of when this is set to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, the
ignore_unknown_columnsparameter is never passed fromWriteToBigqueryto_StreamToBigQueryand therefore never reaches the bq_client's
insert_rows_jsonmethod.Please, let me know if I should add a test case for this, or it's fine like this.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.