Skip to content

[BEAM-4767] Remove beam- prefix from release script tags#16899

Merged
emilymye merged 2 commits intoapache:masterfrom
emilymye:releasescripts
Feb 24, 2022
Merged

[BEAM-4767] Remove beam- prefix from release script tags#16899
emilymye merged 2 commits intoapache:masterfrom
emilymye:releasescripts

Conversation

@emilymye
Copy link
Copy Markdown
Contributor

@emilymye emilymye commented Feb 18, 2022 •
edited by angoenka
Loading

Confirmed, diff for a release branch for 2.37.0 would look like:

-    'dataflow.legacy_container_version' : 'beam-master-20220203',
-    'dataflow.fnapi_container_version' : 'beam-master-20220216',
+    'dataflow.legacy_container_version' : '2.37.0',
+    'dataflow.fnapi_container_version' : '2.37.0',

R: @TheNeuralBit

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions Bot added the build label Feb 18, 2022
TheNeuralBit
TheNeuralBit approved these changes Feb 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I just have a couple questions. It looks like tagging the RC drops the beam-, but just for the fnapi container: 6adfaca#diff-8f2f682def71854816cc757228ece9384fcc753fd338a19dcf2a5b3ccca92185

  • Any chance this will break the logic in the RC tagging script?
  • Is it correct to update both, or should the legacy one still be beam-2.xx.x?

@emilymye
Copy link
Copy Markdown
Contributor Author

emilymye commented Feb 18, 2022 •
edited
Loading

I'll change the cut RC, but see gcr.io/cloud-dataflow/v1beta3/beam_java8_sdk:2.36.0and gcr.io/cloud-dataflow/v1beta3/beam-java-batch:2.36.0 vs gcr.io/cloud-dataflow/v1beta3/beam-java-batch:beam-2.36.0 legacy version that doesn't not exist)

@emilymye emilymye changed the title Remove beam- prefix from release script tags [BEAM-4767] Remove beam- prefix from release script tags Feb 18, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 18, 2022 •
edited
Loading

Codecov Report

Merging #16899 (081612a) into master (f87f146) will increase coverage by 8.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16899      +/-   ##
==========================================
+ Coverage   74.65%   83.60%   +8.95%     
==========================================
  Files         656      452     -204     
  Lines       82424    62302   -20122     
==========================================
- Hits        61532    52088    -9444     
+ Misses      19892    10214    -9678     
+ Partials     1000        0    -1000
Impacted Files Coverage Δ
.../python/apache_beam/testing/test_stream_service.py 88.37% <0.00%> (-4.66%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.74% <0.00%> (-1.86%) ⬇️
.../python/apache_beam/transforms/periodicsequence.py 96.72% <0.00%> (-1.64%) ⬇️
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.51% <0.00%> (-0.13%) ⬇️
sdks/go/pkg/beam/testing/passert/count.go
sdks/go/pkg/beam/core/runtime/xlangx/payload.go
sdks/go/pkg/beam/core/graph/coder/panes.go
sdks/go/pkg/beam/core/graph/coder/row_encoder.go
sdks/go/pkg/beam/core/graph/graph.go
... and 199 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87f146...081612a. Read the comment docs.

@emilymye emilymye merged commit f94a00f into apache:master Feb 24, 2022
@emilymye emilymye deleted the releasescripts branch February 24, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheNeuralBit TheNeuralBit TheNeuralBit approved these changes

Assignees

No one assigned

Labels

build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emilymye @TheNeuralBit