[BEAM-9706][py] Supporting ignore_unknown_values for WriteToBigQuery#16081
Merged
pabloem merged 1 commit intoapache:masterfrom Nov 30, 2021
Merged
[BEAM-9706][py] Supporting ignore_unknown_values for WriteToBigQuery#16081pabloem merged 1 commit intoapache:masterfrom
pabloem merged 1 commit intoapache:masterfrom
Conversation
pabloem
force-pushed
the
ignore-unknown-values
branch
from
7b0dc12 to
11b9411
Compare
Member
Author
|
Run Python 3.8 PostCommit |
Member
Author
|
r: @ihji |
Member
Author
|
or r: @youngoli |
Member
Author
|
(@youngoli since you're becoming familiar with BQ IO lately : )) |
pabloem
force-pushed
the
ignore-unknown-values
branch
from
11b9411 to
496f975
Compare
youngoli
approved these changes
Nov 30, 2021
Contributor
youngoli
left a comment
youngoli
left a comment
There was a problem hiding this comment.
Looks good to me, although I have a question just to confirm I'm understanding it correctly.
Contributor
There was a problem hiding this comment.
Just to make sure I'm not missing anything, this is the main change in functionality right? All the other changes are just passing parameters through function signatures until they get here, right?
pabloem
force-pushed
the
ignore-unknown-values
branch
from
496f975 to
6e7f893
Compare
pabloem
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.