[BEAM-12593] Verify DataFrame API on pandas 1.3 (with container update)#15525
Merged
TheNeuralBit merged 3 commits intoapache:masterfrom Sep 28, 2021
Merged
[BEAM-12593] Verify DataFrame API on pandas 1.3 (with container update)#15525TheNeuralBit merged 3 commits intoapache:masterfrom
TheNeuralBit merged 3 commits intoapache:masterfrom
Conversation
Member
Author
|
Run Python 3.8 PostCommit |
Member
Author
|
Run Python 3.6 PostCommit |
Codecov Report
@@ Coverage Diff @@
## master #15525 +/- ##
==========================================
- Coverage 83.78% 83.76% -0.02%
==========================================
Files 444 444
Lines 60397 60410 +13
==========================================
+ Hits 50601 50604 +3
- Misses 9796 9806 +10
Continue to review full report at Codecov.
|
4 tasks
Member
Author
|
Run Python PreCommit |
TheNeuralBit
changed the title
Member
Author
|
R: @tvalentyn |
Member
Author
|
Note 20cd6b5978a673e00d4b9455d27b59305ec56a3d is a pure re-apply of #15165, which was already reviewed. |
…I on pandas 1.3.0 * [BEAM-12593] Verify DataFrame API on pandas 1.3.0 * Fills correct partitioning for fillna * Add version number to lib * Condition on incompatible version features * Due to BEAM-12495 value_counts with dropna=False does not work on frames * Added NotImplementedError when detecting BEAM-12495 * fix insert/value_counts doc test * update Pandas doctests for groupby for 1.3.x Pandas * test dropna&normalize combinations Co-authored-by: Brian Hulette <[email protected]>
TheNeuralBit
force-pushed
the
pandas-1.3
branch
from
b20237e to
e002382
Compare
Member
Author
|
Run Python 3.8 PostCommit |
Member
Author
|
R: @ibzib |
Contributor
|
Sorry I remember looking at the PR but looks like I forgot to approve. |
tvalentyn
approved these changes
Sep 27, 2021
Member
Author
|
No worries! Thanks for the review :) |
Member
Author
|
Run Python 3.8 PostCommit |
dmitriikuzinepam
pushed a commit
to dmitriikuzinepam/beam
that referenced
this pull request
Nov 2, 2021
…e) (apache#15525) * Merge pull request apache#15165 from [BEAM-12593] Verify DataFrame API on pandas 1.3.0 * [BEAM-12593] Verify DataFrame API on pandas 1.3.0 * Fills correct partitioning for fillna * Add version number to lib * Condition on incompatible version features * Due to BEAM-12495 value_counts with dropna=False does not work on frames * Added NotImplementedError when detecting BEAM-12495 * fix insert/value_counts doc test * update Pandas doctests for groupby for 1.3.x Pandas * test dropna&normalize combinations Co-authored-by: Brian Hulette <[email protected]> * Upgrade to pandas==1.3.3 in Python container Co-authored-by: Sam sam <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-apply #15165 (which was reverted in #15397) with additional commits to bump the pandas version in containers.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.