[BEAM-12724][BEAM-12349] Support user timers in Samza portable runner#15349
Merged
xinyuiscool merged 6 commits intoapache:masterfrom Aug 24, 2021
kw2542:BEAM-12724
Merged
[BEAM-12724][BEAM-12349] Support user timers in Samza portable runner#15349xinyuiscool merged 6 commits intoapache:masterfrom kw2542:BEAM-12724
xinyuiscool merged 6 commits intoapache:masterfrom
kw2542:BEAM-12724
Conversation
1. Support user timers in Samza portable runner 2. Enable user timers tests
Codecov Report
@@ Coverage Diff @@
## master #15349 +/- ##
==========================================
- Coverage 83.80% 83.67% -0.13%
==========================================
Files 441 440 -1
Lines 59801 59950 +149
==========================================
+ Hits 50115 50162 +47
- Misses 9686 9788 +102
Continue to review full report at Codecov.
|
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
|
Run Python PreCommit |
Contributor
Author
|
Run Java Samza PortableValidatesRunner |
Contributor
Author
|
Run Python Samza ValidatesRunner |
Contributor
Author
|
@xinyuiscool @mynameborat @dxichen Can you take a look ? |
xinyuiscool
reviewed
Aug 23, 2021
added 2 commits
August 23, 2021 16:15
xinyuiscool
approved these changes
Aug 23, 2021
Contributor
xinyuiscool
left a comment
xinyuiscool
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding timer support in portable samza runner.
Contributor
Author
|
Run Java Samza PortableValidatesRunner |
Contributor
Author
|
Run Python Samza ValidatesRunner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./gradlew :sdks:python:test-suites:portable:py36:samzaCompatibilityMatrixLOOPBACK --rerun-tasksand./gradlew :runners:samza:job-server:validatesPortableRunnerPlease add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.