[BEAM-10961] Enable strict dependency checking on sdks/java/io/hadoop-format#13799
[BEAM-10961] Enable strict dependency checking on sdks/java/io/hadoop-format#13799aromanenko-dev merged 2 commits intoapache:masterfrom
Conversation
shehzaadn-vd
changed the title
shehzaadn-vd
changed the title
|
LGTM, but we should get a second opinion on the |
|
Run Java HadoopFormatIO Performance Test |
|
Well, I don't know why specific Log4j version was used for testing (it was added even before my code refactoring) but if all tests pass then, seems, we don't need that anymore. So, it LGTM in general for me. Maybe @iemejia recalls something on this. |
|
@shehzaadn-vd Please, don't forget to add a Jira prefix to commit messages as well. |
No idea but in any case even if used it should have not had that scope but |
shehzaadn-vd
force-pushed
the
sdks-io-hadoop
branch
3 times, most recently
from
b78db30 to
465ebeb
Compare
shehzaadn-vd
force-pushed
the
sdks-io-hadoop
branch
from
465ebeb to
3a6669d
Compare
|
@aromanenko-dev I didn't mean to ignore your comment about jira prefixes on commit messages. I just saw it late. Apologies. Hope I can get a pass this time! |
|
@shehzaadn-vd Not a problem, I'll squash before merge and fix a comment message |
4 participants
Moved here from PR# 13688 per @ibzib's request.
R: @ibzib, please add other folks if needed.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.