Skip to content

Comments

Move row_filter async tests from parquet async reader#9355

Merged
alamb merged 7 commits intoapache:mainfrom
sdf-jkl:split-tests3
Feb 5, 2026
Merged

Move row_filter async tests from parquet async reader#9355
alamb merged 7 commits intoapache:mainfrom
sdf-jkl:split-tests3

Conversation

@sdf-jkl
Copy link
Contributor

@sdf-jkl sdf-jkl commented Feb 4, 2026

Which issue does this PR close?

Push after #9354 where TestReader is moved to a common place for other async reader tests.

Rationale for this change

What changes are included in this PR?

  • Move sync tests from parquet/tests/arrow_reader/row_filter.rs to parquet/tests/arrow_reader/row_filter/sync.rs
  • Move async tests from parquet/src/async_reader/mod.rs to parquet/tests/arrow_reader/row_filter/async.rs

Are these changes tested?

Code movement

Are there any user-facing changes?

Code movement

@github-actions github-actions bot added the parquet Changes to the parquet crate label Feb 4, 2026
@sdf-jkl sdf-jkl marked this pull request as ready for review February 4, 2026 23:17
@sdf-jkl
Copy link
Contributor Author

sdf-jkl commented Feb 4, 2026

@alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sdf-jkl

Also thank you for keeping the diffs small

@alamb alamb merged commit 6cb4287 into apache:main Feb 5, 2026
16 checks passed
@sdf-jkl sdf-jkl deleted the split-tests3 branch February 5, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants