Skip to content

Comments

Move bloom filter tests from parquet reader#9354

Merged
alamb merged 7 commits intoapache:mainfrom
sdf-jkl:split-tests2
Feb 4, 2026
Merged

Move bloom filter tests from parquet reader#9354
alamb merged 7 commits intoapache:mainfrom
sdf-jkl:split-tests2

Conversation

@sdf-jkl
Copy link
Contributor

@sdf-jkl sdf-jkl commented Feb 4, 2026

Which issue does this PR close?

Rationale for this change

check issues

What changes are included in this PR?

  • Moved bloom filter tests out of sync and async readers to parquet/tests/bloom_filter/
  • Moved TestReader out of parquet/tests/arrow_reader/predicate_cache.rs

Are these changes tested?

Code movement

Are there any user-facing changes?

Code movement

@github-actions github-actions bot added the parquet Changes to the parquet crate label Feb 4, 2026
@sdf-jkl sdf-jkl marked this pull request as ready for review February 4, 2026 17:43
@sdf-jkl
Copy link
Contributor Author

sdf-jkl commented Feb 4, 2026

@alamb

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @sdf-jkl

@alamb alamb added the development-process Related to development process of arrow-rs label Feb 4, 2026
@alamb alamb merged commit 537c10a into apache:main Feb 4, 2026
16 checks passed
@sdf-jkl sdf-jkl deleted the split-tests2 branch February 4, 2026 22:07
alamb pushed a commit that referenced this pull request Feb 5, 2026
# Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax.
-->

Push after #9354 where `TestReader` is moved to a common place for other
async reader tests.

- Part of #9348.
- Will help with #9118

# Rationale for this change

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

# What changes are included in this PR?
- Move sync tests from `parquet/tests/arrow_reader/row_filter.rs` to
`parquet/tests/arrow_reader/row_filter/sync.rs`
- Move async tests from `parquet/src/async_reader/mod.rs` to
`parquet/tests/arrow_reader/row_filter/async.rs`

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

# Are these changes tested?
Code movement
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

# Are there any user-facing changes?
Code movement
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.

If there are any breaking changes to public APIs, please call them out.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of arrow-rs parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants