[57_maintenance] Revert "Seal Array trait (#9092)", mark Array as unsafe (#9234)#9313
Merged
alamb merged 1 commit intoapache:57_maintenancefrom Feb 2, 2026
Merged
Conversation
…ache#9234) This reverts commit 721f373. # Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Discussed in apache#9184 - Closes apache#9184 # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> As discussed in Discussed in apache#9184, rather than sealing the `Array` trait, it's going to potentially be marked `unsafe` so that projects have time to find alternatives for their use-cases that are now satisfied by a custom `Array` implementation. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Clean revert of apache#9092 # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Not applicable here # Are there any user-facing changes? Yes, users can no implement the `Array` trait in their codebases again. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. -->
10 tasks
Array as unsafe (#9234)Array as unsafe (#9234)
gabotechs
approved these changes
Jan 30, 2026
Jefffrey
approved these changes
Feb 2, 2026
Contributor
Author
|
Thanks @gabotechs and @Jefffrey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
57.3.0(January 2026) #9240Arraytrait broke downstream crates #9184This is a backport of the following PR to the 57 line
Arrayasunsafe#9234 from @gabotechsAs discussed in #9184, rather than sealing the Array trait which broke several downstream crates, this PR markes the trait as
unsafeso that projects have time to find alternatives for their use-cases that are now satisfied by a custom Array implementation.