Skip to content

Comments

[57_maintenance] Revert "Seal Array trait (#9092)", mark Array as unsafe (#9234)#9313

Merged
alamb merged 1 commit intoapache:57_maintenancefrom
alamb:alamb/backport_unseal_and_unsafe
Feb 2, 2026
Merged

[57_maintenance] Revert "Seal Array trait (#9092)", mark Array as unsafe (#9234)#9313
alamb merged 1 commit intoapache:57_maintenancefrom
alamb:alamb/backport_unseal_and_unsafe

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Jan 30, 2026

This is a backport of the following PR to the 57 line

As discussed in #9184, rather than sealing the Array trait which broke several downstream crates, this PR markes the trait as unsafe so that projects have time to find alternatives for their use-cases that are now satisfied by a custom Array implementation.

…ache#9234)

This reverts commit 721f373.

# Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax.
-->

- Discussed in apache#9184
- Closes apache#9184
 
# Rationale for this change

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

As discussed in Discussed in
apache#9184, rather than sealing the
`Array` trait, it's going to potentially be marked `unsafe` so that
projects have time to find alternatives for their use-cases that are now
satisfied by a custom `Array` implementation.


# What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

Clean revert of apache#9092

# Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

Not applicable here

# Are there any user-facing changes?

Yes, users can no implement the `Array` trait in their codebases again.

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.

If there are any breaking changes to public APIs, please call them out.
-->
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 30, 2026
@alamb alamb changed the title [maintenance_57] Revert "Seal Array trait (#9092)", mark Array as unsafe (#9234) [57_maintenance] Revert "Seal Array trait (#9092)", mark Array as unsafe (#9234) Jan 30, 2026
@alamb
Copy link
Contributor Author

alamb commented Feb 2, 2026

Thanks @gabotechs and @Jefffrey

@alamb alamb merged commit 505eb8e into apache:57_maintenance Feb 2, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants