Skip to content

Comments

[57_maintenance] fix: ensure BufferBuilder::truncate doesn't overset length (#9288)#9311

Merged
alamb merged 1 commit intoapache:57_maintenancefrom
alamb:alamb/backport_truncate
Feb 2, 2026
Merged

[57_maintenance] fix: ensure BufferBuilder::truncate doesn't overset length (#9288)#9311
alamb merged 1 commit intoapache:57_maintenancefrom
alamb:alamb/backport_truncate

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Jan 30, 2026

…9288)

# Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax.
-->

- Closes apache#9286

# Rationale for this change

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

Miri reports undefined behaviour because `truncate` didn't check new
length when setting the length for `BufferBuilder`, meaning when used in
conjunction with `as_slice_mut` the pointer could potentially be
dereferenced for memory beyond its allocation.

# What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

Ensure we bound length in BufferBuilder so truncating to a larger length
does not change the length.

# Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

Added test.

# Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.

If there are any breaking changes to public APIs, please call them out.
-->

No.
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 30, 2026
@alamb alamb merged commit 25cc1ac into apache:57_maintenance Feb 2, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants