Mark boolean comparison kernels public#913
Merged
alamb merged 1 commit intoapache:masterfrom Nov 4, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #913 +/- ##
=======================================
Coverage 82.29% 82.30%
=======================================
Files 168 168
Lines 48028 48028
=======================================
+ Hits 39526 39530 +4
+ Misses 8502 8498 -4
Continue to review full report at Codecov.
|
Contributor
Author
LOL I should have caught it in review |
alamb
added a commit
that referenced
this pull request
Nov 4, 2021
alamb
added a commit
that referenced
this pull request
Nov 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #912
Rationale for this change
The boolean kernels added in #844 by @Dandandan are not marked
puband thus can not be used. For example:https://docs.rs/arrow/6.1.0/arrow/compute/kernels/comparison/index.html?search=eq_bool
What changes are included in this PR?
mark the boolean kernels public
Are there any user-facing changes?
kernels are usable