Add examples for min and max functions #9062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
reviewed
Dec 30, 2025
arrow-arith/src/aggregate.rs
Outdated
| /// ```rust | ||
| /// # use arrow_array::Int32Array; | ||
| /// # use arrow_arith::aggregate::min; | ||
| /// let array = Int32Array::from(vec![5, 6, 7, 8, 9]); |
Contributor
There was a problem hiding this comment.
Perhaps shuffle the input here?
Contributor
Author
There was a problem hiding this comment.
Updated. Thanks!
Jefffrey
approved these changes
Dec 30, 2025
Contributor
|
Thanks @EduardAkhmetshin |
Jefffrey
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Changes to docstrings for
minandmaxfunctions.Are these changes tested?
Yes
Are there any user-facing changes?
Yes. These doc pages will be updated:
https://docs.rs/arrow/latest/arrow/compute/fn.min.html
https://docs.rs/arrow/latest/arrow/compute/fn.max.html