Move RunArray::get_physical_indices to RunEndBuffer#9027
Merged
alamb merged 1 commit intoapache:mainfrom Dec 23, 2025
Merged
Conversation
lyang24
force-pushed
the
refactor_get_physical_indexes
branch
from
c7a40cd to
f01df57
Compare
Jefffrey
reviewed
Dec 22, 2025
arrow-buffer/src/buffer/run.rs
Outdated
| /// | ||
| /// Returns an error if any logical index is out of bounds (>= self.len()). | ||
| #[inline] | ||
| pub fn get_physical_indices<I>(&self, logical_indices: &[I]) -> Result<Vec<usize>, String> |
Contributor
There was a problem hiding this comment.
Maybe we could have return type as Result<Vec<usize>, I>, and return the offending input logical index that caused the error instead of a string message? Leave it up to consumers to format their own message 🤔
lyang24
force-pushed
the
refactor_get_physical_indexes
branch
from
f01df57 to
3266580
Compare
Jefffrey
reviewed
Dec 22, 2025
Signed-off-by: lyang24 <[email protected]>
lyang24
force-pushed
the
refactor_get_physical_indexes
branch
from
3266580 to
7bda254
Compare
Jefffrey
approved these changes
Dec 22, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
RunArray::get_physical_indicestoRunEndBuffer#9025.Rationale for this change
clear a todo.
What changes are included in this PR?
Moved the core implementation from RunArray to RunEndBuffer
Are these changes tested?
this is a simple refactor
Are there any user-facing changes?
no