fix: display 0 secs for empty DayTime/MonthDayNano intervals#9023
Merged
Jefffrey merged 3 commits intoapache:mainfrom Jan 10, 2026
Merged
fix: display 0 secs for empty DayTime/MonthDayNano intervals#9023Jefffrey merged 3 commits intoapache:mainfrom
0 secs for empty DayTime/MonthDayNano intervals#9023Jefffrey merged 3 commits intoapache:mainfrom
Conversation
friendlymatthew
approved these changes
Dec 22, 2025
Contributor
friendlymatthew
left a comment
friendlymatthew
left a comment
There was a problem hiding this comment.
Wowza, very nice catch! Btw I think CI is hung?
Contributor
Author
CI failure seems unrelated, see #9024 |
alamb
approved these changes
Jan 9, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @Jefffrey and @friendlymatthew
1 task
Dandandan
pushed a commit
to Dandandan/arrow-rs
that referenced
this pull request
Jan 15, 2026
…e#9023) # Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes apache#5914 # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> See apache#5914 (comment) # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> If DayTime/MonthDayNano intervals are empty, write `0 secs` for display. # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Updated existing tests. # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. --> Minor change in display behaviour (previously wrote out an empty string) Co-authored-by: Andrew Lamb <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
See #5914 (comment)
What changes are included in this PR?
If DayTime/MonthDayNano intervals are empty, write
0 secsfor display.Are these changes tested?
Updated existing tests.
Are there any user-facing changes?
Minor change in display behaviour (previously wrote out an empty string)