Support parsing for old style FixedSizeList#8882
Merged
alamb merged 1 commit intoapache:mainfrom Nov 20, 2025
Merged
Conversation
alamb
changed the title
alamb
force-pushed
the
alamb/fix_fixed_size_parsing
branch
from
7556aee to
0be89de
Compare
etseidl
approved these changes
Nov 19, 2025
Contributor
etseidl
left a comment
etseidl
left a comment
There was a problem hiding this comment.
This looks correct to my untrained eye.
Comment on lines
+178
to
+179
| /// * `FixedSizeList(5 x nullable Int64, field: 'foo')` | ||
| /// * `FixedSizeList(4, Int64)` |
Contributor
There was a problem hiding this comment.
New to this code...should FixedSizeList(5 x Int64) also parse and produce a list with non-nullable elements?
Contributor
Author
There was a problem hiding this comment.
Yes -- it is already (implicitly) covered by the round trip tests, but I think you are right that an additional explicit test would be best
| } | ||
| // `FixedSizeList(4, Int64)` format | ||
| Token::Comma => { | ||
| let data_type = self.parse_next_type()?; |
Contributor
There was a problem hiding this comment.
I checked the original code and this seems correct to me.
Contributor
Author
|
Thanks for the review @etseidl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
List,ListView,LargeList,LargeListView,FixedSizeList#8649 change the default display for List and LargeList and FixedSizeList, and changed the parsing code to match.However, to maintain backwards compatibility we also need to support the old syntax too
What changes are included in this PR?
WIP
Are these changes tested?
WIP
Are there any user-facing changes?