Merged
Conversation
alamb
commented
Oct 31, 2025
| @@ -52,8 +52,7 @@ async fn test_default_read() { | |||
| #[tokio::test] | |||
| async fn test_async_cache_with_filters() { | |||
| let test = ParquetPredicateCacheTest::new().with_expected_records_read_from_cache(49); | |||
| let async_builder = test.async_builder().await; | |||
| let async_builder = test.add_project_ab_and_filter_b(async_builder); | |||
| let async_builder = test.async_builder().await.add_project_ab_and_filter_b(); | |||
Contributor
Author
There was a problem hiding this comment.
This is the key change -- move the logic to add specific filters to an extension trait rather than a methog on the ParquetPredicateCacheTest test fixture
alamb
force-pushed
the
alamb/rewrite_tests2
branch
from
185af9f to
fbfc545
Compare
alamb
commented
Nov 1, 2025
| .unwrap() | ||
| } | ||
|
|
||
| /// Return a [`ParquetRecordBatchReaderBuilder`] for reading the file with |
Contributor
Author
There was a problem hiding this comment.
this code was moved to a new trait -- but the logic is the same
Contributor
Author
|
Thank you @etseidl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
test_cache_projection_excludes_nested_columnsto use high level APIs #8754Rationale for this change
While working on #8754 I found the current formulation a bit akward so let's fix that
What changes are included in this PR?
Move the builder configuration to a trait so the tests read more fluently.
This is totally unecessary, it just makes me feel better about the tests
Are these changes tested?
Yes by CI
Are there any user-facing changes?
No this is test only