chore: replace paste with pastey#8590
Closed
DCjanus wants to merge 1 commit intoapache:mainfrom
DCjanus:main
Closed
chore: replace paste with pastey#8590DCjanus wants to merge 1 commit intoapache:mainfrom DCjanus:main
DCjanus wants to merge 1 commit intoapache:mainfrom
DCjanus:main
Conversation
github-actions
bot
added
parquet
Contributor
|
I feel like there might actually be more risk with a new crate than sticking with the old crate -- even if it is 'unmaintained' if it doesn't need maintenance then what is the harm If we really want to remove the dependency on paste, I think it would be better to vendor it into arrow (aka copy the relevant parts we need) |
Contributor
|
Thank you for this contribution @DCjanus |
Author
I think I'm convinced, perhaps we can keep things as they are for now, until one day we need to change it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• # Which issue does this PR close?
paste#7598Rationale for this change
cargo deny flags the unmaintained paste crate, so advisory checks fail until we remove it. Switching to the maintained drop-in replacement keeps the dependency tree healthy and restores the advisory gate.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
No user-facing changes or API adjustments.