Skip to content

Conversation

@etseidl
Copy link
Contributor

@etseidl etseidl commented Sep 25, 2025

Which issue does this PR close?

Rationale for this change

See issue.

What changes are included in this PR?

Replaces starts_with on concatenated paths with an element-by-element search of path components.

Are these changes tested?

Yes, added a new test based on the issue

Are there any user-facing changes?

No, just a bug fix

@github-actions github-actions bot added the parquet Changes to the parquet crate label Sep 25, 2025
@etseidl
Copy link
Contributor Author

etseidl commented Sep 25, 2025

cc @mapleFU

@mapleFU
Copy link
Member

mapleFU commented Sep 26, 2025

General ok to me

@alamb alamb self-requested a review September 26, 2025 17:40
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thanks @etseidl and @mapleFU

@alamb alamb merged commit 4b62c80 into apache:main Oct 2, 2025
16 checks passed
@alamb alamb added the api-change Changes to the arrow API label Oct 2, 2025
@etseidl etseidl deleted the fix_col_projection branch October 2, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change Changes to the arrow API parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Parquet] ProjectionMask::columns name handling is bug prone

3 participants