[Variant] Make VariantToArrowRowBuilder an enum #8345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@alamb -- interested to hear your thoughts on this change? |
alamb
approved these changes
Sep 15, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @scovich -- I think this looks like a nice change to me
I am not sure I have ever seen the overhead of an enum vs trait measured or really making a difference, but I personally do find the enums easier to work with and removing Box'es (aka allocations) is never a bad idea in my opinion as long as it doesn't make the code harder to understand
So all in all, 👍
cc @codephage2020 and @klion26
| data_type: Option<&'a datatypes::DataType>, | ||
| data_type: Option<&'a DataType>, | ||
| cast_options: &'a CastOptions, | ||
| ) -> Result<Box<dyn VariantToArrowRowBuilder + 'a>> { |
Contributor
There was a problem hiding this comment.
Remioving this Box seems like a good idea to me.
mbrobbel
reviewed
Sep 15, 2025
mbrobbel
approved these changes
Sep 15, 2025
Member
|
Thanks @scovich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
Rationale for this change
Enum dispatch in rust is more efficient than virtual method dispatch, and enums require far less boxing which makes them more memory efficient as well.
ArrowToVariantRowBuilderis already an enum, so it makes sense forVariantToArrowRowBuilderto take the same approach.What changes are included in this PR?
Replace the trait with an enum.
Are these changes tested?
Yes, existing row builder tests continue to pass.
Are there any user-facing changes?
No.