[Variant] Add tests for variant_get requesting Some struct #8343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CC @alamb @codephage2020 -- another quickie (once the PR it depends on merges) |
klion26
approved these changes
Sep 15, 2025
Member
There was a problem hiding this comment.
Does the comment dummy value for row 2 here mean that row 2 is inner field null?
Member
There was a problem hiding this comment.
Does this(row 3) mean writer did not respect the variant spec?
Contributor
Author
There was a problem hiding this comment.
on null rows, the array can contain any physically valid value; it will anyway be ignored
Contributor
Author
There was a problem hiding this comment.
(and they have to contain something to keep row counts in sync)
scovich
force-pushed
the
variant-get-struct-tests
branch
from
bf83990 to
7328d19
Compare
codephage2020
approved these changes
Sep 15, 2025
Contributor
codephage2020
left a comment
codephage2020
left a comment
There was a problem hiding this comment.
Looks good to me ! Thank you !
mbrobbel
approved these changes
Sep 15, 2025
Contributor
Author
|
@mbrobbel -- any reason not to merge this? (I don't have rights) |
Contributor
|
woohoo we are cooking the last few days in arrow-rs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
Rationale for this change
variant_gethas code to support reading a struct from perfectly shredded variant data, but no test coverage.What changes are included in this PR?
Add the missing coverage.
Are these changes tested?
Yes
Are there any user-facing changes?
No