Minor: avoid an Arc::clone in CacheOptions for Parquet PredicateCache
#8338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
Arc::clone in CacheOptions for Parquet PredicateCache
alamb
commented
Sep 12, 2025
|
|
||
| let cache_options_builder = | ||
| CacheOptionsBuilder::new(&cache_projection, row_group_cache.clone()); | ||
| let cache_options_builder = CacheOptionsBuilder::new(&cache_projection, &row_group_cache); |
Contributor
Author
There was a problem hiding this comment.
The "major" change in this PR is to remove this clone
etseidl
approved these changes
Sep 12, 2025
Contributor
etseidl
left a comment
etseidl
left a comment
There was a problem hiding this comment.
Looks like a sensible cleanup. Might also save a few microseconds 🤣
mbrobbel
approved these changes
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I found this while working on #7997
Basically, the fact that the CacheOptionsBuilder had both owned and non owned fields made it a bit akward to work with -- if it is going to be zero copy (references) we pay the price of tracking lifetimes already. We may as well just do so for the Arc as well
I don't expect this to make any measurable different in performance. I am mostly treating it as a cleanup
What changes are included in this PR?
Remove one Arc::clone
Are these changes tested?
By existing CI
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.