Fix can_cast_types for temporal to Utf8View
#8328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cast` and `cast_with_options` gained support for casting from temporal values to `Utf8View` in e613622. This updates `can_cast_types` to match. This is necessary for DataFusion to use this casts, as DF consults `can_cast_types` first.
alamb
approved these changes
Sep 13, 2025
| macro_rules! assert_cast_timestamp_to_string { | ||
| macro_rules! assert_cast { | ||
| ($array:expr, $datatype:expr, $output_array_type: ty, $expected:expr) => {{ | ||
| assert!(can_cast_types($array.data_type(), &$datatype)); |
findepi
deleted the
findepi/fix-can-cast-types-for-temporal-to-utf8view-7bf7d1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
castandcast_with_optionsgained support for casting from temporal values toUtf8Viewin e613622. This updatescan_cast_typesto match. This is necessary for DataFusion to use this casts, as DF consultscan_cast_typesfirst.