perf(arrow-ipc): avoid counting nulls in RecordBatchDecoder
#8127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this uses the `null_count()`` on `FieldNode` instead of calculating it each time
Member
Author
|
Not sure about adding a test, I can add a test for creating an invalid null length and see that it fails, but this will have the same result before and now, so that test should already exist regardless. and about benchmarks, no I did not run any nor do I have any, any IPC reading benchmark for arrays that have nulls in them will suffice. |
Dandandan
approved these changes
Aug 14, 2025
Contributor
Dandandan
left a comment
Dandandan
left a comment
There was a problem hiding this comment.
LGTM, null counting probably is probably not the most expensive part, but good to avoid it regardless :)
Contributor
|
Thanks @rluvaton and @Dandandan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
The Arrow IPC format already contain the null count for each array, reusing it instead of calculating each time to improve performance
What changes are included in this PR?
Update the
create_arrayinRecordBatchDecoderto use the null count when creatingArrayDataBuilderAre these changes tested?
Existing tests
Are there any user-facing changes?
No